| To: | Nathan Scott <nscott@xxxxxxxxxx> |
|---|---|
| Subject: | Re: pidfile change breaks qa test which run non-root pmcd |
| From: | Michael Newton <kimbrr@xxxxxxx> |
| Date: | Tue, 24 Jul 2007 14:11:28 +1000 |
| Cc: | pcp@xxxxxxxxxxx |
| In-reply-to: | <1185246832.10702.54.camel@xxxxxxxxxxxxxx> |
| References: | <Pine.SGI.4.58.0707241128260.33521098@xxxxxxxxxxxxxxxxxxxxxxx> <1185246832.10702.54.camel@xxxxxxxxxxxxxx> |
| Sender: | pcp-bounce@xxxxxxxxxxx |
On Tue, 24 Jul 2007, Nathan Scott wrote: > On Tue, 2007-07-24 at 11:32 +1000, Michael Newton wrote: > > Several QA tests run pmcd -f & > > With the pidfile change, they break because they dont have > > write permission on the pidfile. Here's a fix > > > > The pidfile shouldn't be created when running pmcd with -f - this is a > debugging option, and it shouldn't require root priveleges to run pmcd > this way. fair enough (tho some of the tests already do other fiddly logger/config chmods related to not being root). While im working on that, another review (to follow), to reinstate a fallback to SIGKILL when TERM doesnt work ps: qa/003 will need looking at in light of, eg, sample.darkness.. but i wont let that hold up the release. There'll no doubt be others tho.. |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: pidfile change breaks qa test which run non-root pmcd, Nathan Scott |
|---|---|
| Next by Date: | in /etc/init.d/pcp, if TERM doesnt work, try KILL, Michael Newton |
| Previous by Thread: | Re: pidfile change breaks qa test which run non-root pmcd, Nathan Scott |
| Next by Thread: | in /etc/init.d/pcp, if TERM doesnt work, try KILL, Michael Newton |
| Indexes: | [Date] [Thread] [Top] [All Lists] |