pcp
[Top] [All Lists]

Re: Review: PCP & pmlogger take too long to start

To: Michael Newton <kimbrr@xxxxxxx>
Subject: Re: Review: PCP & pmlogger take too long to start
From: Nathan Scott <nscott@xxxxxxxxxx>
Date: Mon, 02 Jul 2007 16:02:21 +1000
Cc: pcp@xxxxxxxxxxx
In-reply-to: <1183355238.15488.217.camel@xxxxxxxxxxxxxx>
Organization: Aconex
References: <Pine.SGI.4.58.0706271012280.2186626@xxxxxxxxxxxxxxxxxxxxxxx> <Pine.SGI.4.58.0706271124250.2186626@xxxxxxxxxxxxxxxxxxxxxxx> <Pine.SGI.4.58.0706271715321.2351218@xxxxxxxxxxxxxxxxxxxxxxx> <1182996127.15488.102.camel@xxxxxxxxxxxxxx> <Pine.SGI.4.58.0706291810180.4792701@xxxxxxxxxxxxxxxxxxxxxxx> <1183355238.15488.217.camel@xxxxxxxxxxxxxx>
Reply-to: nscott@xxxxxxxxxx
Sender: pcp-bounce@xxxxxxxxxxx
BTW, one other thing I noticed here in the pmie and pmlogger
check scripts - theres a comment near the start of the loop
in _check_logger() that doesn't match what the code does.
And the code looks wrong - the comment is:

# $logfile was previously removed, if it has appeared again
# then we know pmlogger has started ... if not just sleep and
# try again

But what it actually seems to do is sleep when pmlogger has
started, just prior to returning from the call (when we know
pmlogger has started...).  The attached patch fixes this up,
and implements what the comment (correctly, I believe) says.
[ This is an incremental patch on top of my previous patch. ]

Thoughts?

cheers.

--
Nathan

Attachment: fix-startup-extra-sleep
Description: Text Data

<Prev in Thread] Current Thread [Next in Thread>