This is a review request. PCP takes >12s to start, and pmlogger_check >10s
(in the cases where its actually trying to start a pmlogger).
On Tue, 26 Jun 2007, markgw@xxxxxxx via BugWorks wrote:
> please post a summary of what you're intending to fix as a review
> request to pcp@xxxxxxxxxxx (and to this PV).
ok, here it is. This is the 1st time I've gone this way.. i assume i'll
commit as soon as i get a (favourable) review someone?
===========================================================================
mgmt/pcp/src/pmcd/src/agent.c
===========================================================================
--- a/mgmt/pcp/src/pmcd/src/agent.c 2007-06-26 17:31:20.000000000 +1000
+++ b/mgmt/pcp/src/pmcd/src/agent.c 2007-06-26 14:28:22.912602167 +1000
@@ -166,7 +166,7 @@
found = 0;
for ( i = 0; i < nAgents; i++) {
ap = &agent[i];
- if (!ap->status.connected)
+ if (!ap->status.connected || ap->ipcType == AGENT_DSO)
continue;
found = 1;
===========================================================================
mgmt/pcp/src/pmie/pmie_check.sh
===========================================================================
--- a/mgmt/pcp/src/pmie/pmie_check.sh 2007-06-26 17:31:20.000000000 +1000
+++ b/mgmt/pcp/src/pmie/pmie_check.sh 2007-06-26 17:30:37.324129334 +1000
@@ -286,7 +286,7 @@
then
:
else
- sleep 5
+ sleep 1
$VERBOSE && echo " done"
return 0
fi
@@ -313,8 +313,8 @@
return 1
fi
fi
- sleep 5
- i=`expr $i + 5`
+ sleep 1
+ i=`expr $i + 1`
done
$VERBOSE || _message restart
echo " timed out waiting!"
===========================================================================
mgmt/pcp/src/pmlogctl/pmlogger_check.sh
===========================================================================
--- a/mgmt/pcp/src/pmlogctl/pmlogger_check.sh 2007-06-26 17:31:20.000000000
+1000
+++ b/mgmt/pcp/src/pmlogctl/pmlogger_check.sh 2007-06-26 17:26:40.439471251
+1000
@@ -207,7 +207,7 @@
then
:
else
- sleep 5
+ sleep 1
$VERBOSE && echo " done"
return 0
fi
@@ -244,8 +244,8 @@
return 1
fi
fi
- sleep 5
- i=`expr $i + 5`
+ sleep 1
+ i=`expr $i + 1`
done
$VERBOSE || _message restart
echo " timed out waiting!"
===========================================================================
mgmt/pcp/src/pmlogctl/pmnewlog.sh
===========================================================================
--- a/mgmt/pcp/src/pmlogctl/pmnewlog.sh 2007-06-26 17:31:20.000000000 +1000
+++ b/mgmt/pcp/src/pmlogctl/pmnewlog.sh 2007-06-26 17:27:52.761899495 +1000
@@ -106,7 +106,7 @@
then
:
else
- sleep 5
+ sleep 1
$VERBOSE && echo " done"
return 0
fi
@@ -120,8 +120,8 @@
_check_logfile
return 1
fi
- sleep 5
- i=`expr $i + 5`
+ sleep 1
+ i=`expr $i + 1`
done
$VERBOSE || _message restart
echo " timed out waiting!"
--
Dr.Michael("Kimba")Newton kimbrr@xxxxxxx
|