pcp
[Top] [All Lists]

[PATCH] fix dbpmda agent execvp use

To: Michael Newton <kimbrr@xxxxxxx>, Mark Goodwin <markgw@xxxxxxx>
Subject: [PATCH] fix dbpmda agent execvp use
From: Nathan Scott <nscott@xxxxxxxxxx>
Date: Mon, 27 Nov 2006 17:03:30 +1100
Cc: pcp@xxxxxxxxxxx
Organization: Aconex
Reply-to: nscott@xxxxxxxxxx
Sender: pcp-bounce@xxxxxxxxxxx
Hi guys,

When using dbpmda with a new agent thats being invoked with no arguments
I'm hitting a problem where the execvp(2) syscall is not being made with
a NULL terminated argv.  This causes spurious bogus arguments to be on
the agents command line, and messes up their argv/argc handling.

This is fixed by the attached patch.  It looks like a coding oversight,
as this extra addarglist(NULL) _is_ there for the non-short-circuit case
further down in doargs().

cheers.

-- 
Nathan

Attachment: fix-dbpmda-args
Description: Text Data

<Prev in Thread] Current Thread [Next in Thread>
  • [PATCH] fix dbpmda agent execvp use, Nathan Scott <=