pcp
[Top] [All Lists]

pcp-2.3.0-12 now available (was Re: [announce] PCP 2.3.0-11 available fo

To: Ken McDonell <kenmcd@xxxxxxxxxxxxxxxxx>
Subject: pcp-2.3.0-12 now available (was Re: [announce] PCP 2.3.0-11 available for testing)
From: Mark Goodwin <markgw@xxxxxxx>
Date: Mon, 17 Feb 2003 17:52:54 +1100 (EST)
Cc: Troy Dawson <dawson@xxxxxxxx>, <pcp@xxxxxxxxxxx>
In-reply-to: <Pine.SGI.4.40.0302171434070.14254395-100000@xxxxxxxxxxxxxxxxxxxxxxxx>
Sender: pcp-bounce@xxxxxxxxxxx
I have fixed the pmcd segfault for kernels without CONFIG_MODULES
and uploaded pcp-2.3.0-12 to ftp://oss.sgi.com/projects/pcp/download/dev

Both tarball and SRPM formats available. Please test, particularly those
that run kernels without module support (David Douthitt and maybe Troy).
For those interested, here's the patch:

--- /usr/tmp/TmpDir.1751-0/src/pmdas/linux/ksym.c_1.5   Mon Feb 17 16:52:05 2003
+++ src/pmdas/linux/ksym.c      Mon Feb 17 16:47:06 2003
@@ -89,15 +89,17 @@
     int i, res;
     
     for (i = 0; i < maxix; i++) {
-        res = strcmp(ksym_a[i].name, name);
-        if (res > 0) 
-            break;
-        if (res == 0) {
-            if (addr == ksym_a[i].addr)
-                return KSYM_FOUND;
-            else
-                return KSYM_FOUND_MISMATCH;
-        }
+       if (ksym_a[i].name) {
+           res = strcmp(ksym_a[i].name, name);
+           if (res > 0) 
+               break;
+           if (res == 0) {
+               if (addr == ksym_a[i].addr)
+                   return KSYM_FOUND;
+               else
+                   return KSYM_FOUND_MISMATCH;
+           }
+       }
     }
     
     return KSYM_NOT_FOUND;
@@ -476,6 +478,6 @@
        }
     }
     
-    if (read_ksyms(&end_addr)) /* read /proc/ksyms first */
+    if (read_ksyms(&end_addr) > 0) /* read /proc/ksyms first */
        read_sysmap(end_addr);  /* then System.map  */
 }


<Prev in Thread] Current Thread [Next in Thread>