pcp
[Top] [All Lists]

Units wrong for proc.psinfo.rss_rlim

To: pcp@xxxxxxxxxxx
Subject: Units wrong for proc.psinfo.rss_rlim
From: Mike Mason <mmlnx@xxxxxxxxxx>
Date: 31 Jan 2002 16:29:38 -0800
Sender: owner-pcp@xxxxxxxxxxx
The units for proc.psinfo.rss_rlim should be defined as Kbytes, but are
currently undefined even though rss_rlim is clearly converted from bytes
to Kbytes further down in pmda.c

I've attached a patch that fixes the problem.

Mike Mason


--- pcp-2.2.2.orig/src/pmdas/linux/pmda.c       Mon Dec 10 17:52:09 2001
+++ pcp-2.2.2.new/src/pmdas/linux/pmda.c        Thu Jan 31 15:27:13 2002
@@ -1096,7 +1096,7 @@
 /* proc.psinfo.rss_rlim */
   { NULL,
     { PMDA_PMID(CLUSTER_PID_STAT,24), PM_TYPE_U32, PROC_INDOM, PM_SEM_INSTANT, 
-    PMDA_PMUNITS(0,0,0,0,0,0) } },
+    PMDA_PMUNITS(1,0,0,PM_SPACE_KBYTE,0,0) } },
 
 /* proc.psinfo.start_code */
   { NULL,




<Prev in Thread] Current Thread [Next in Thread>
  • Units wrong for proc.psinfo.rss_rlim, Mike Mason <=