pcp
[Top] [All Lists]

Re: bug in /proc/stat parsing on linux 2.4...

To: gilly <gilly@xxxxxxxxxx>
Subject: Re: bug in /proc/stat parsing on linux 2.4...
From: Mark Goodwin <markgw@xxxxxxx>
Date: Wed, 29 Aug 2001 07:32:16 +1000 (EST)
Cc: pcp@xxxxxxxxxxx
In-reply-to: <01c401c12fa4$73542180$2a04000a@exanet>
Sender: owner-pcp@xxxxxxxxxxx
On Tue, 28 Aug 2001, gilly wrote:

> In the linux PMDA, in proc_stat.c file (parsing of /proc/stat file) there's
> a different parsing for 2.4 kernels and 2.2 ones. I'm running on 2.4.6 linux
> kernel and in /proc/stat the line says:
> "disk_io:............." (disk io stats for all devices) includes 5
> parameters, and not 4 as expected in proc_stat.c:
> instead of - (X,Y):(RIO,RBLK,WIO,WBLK),
> the line is - (X,Y):(TOTALIO*,RIO,RBLK,WIO,WBLK)
> *(TOTALIO = RIO + WIO)
> Attached is an example for /proc/stat file in 2.4.6 linux kernel & a fix for
> this bug.

thanks, it looks like you are correct and I have applied your patch. Most
of the machines around here have the "sard" patch applied (which gives
extra I/O accounting in /proc/partitions) and if sard stats are available
then /proc/stat is not used for disk stats.

-- Mark


<Prev in Thread] Current Thread [Next in Thread>