Hello,
Here's my list of bugs and their correction for the latest
PCP version.
------------
In pcp.conf.in, there is
PCP_CPP_PROG=@cpp_simple@@cpp_simple_args@
But when it is replaced, it gives something like this:
PCP_CPP_PROG=/lib/cpp -P -traditional -undef
Which is wrong as it is interpreted as having the /lib/cpp
content into PCP_CPP_PROG and to execute the program
'-P -traditional -undef' ! So when I run /etc/init.d/pcp start,
I get an error saying 'Program -P not found'.
The correction is to add quotes, like this:
PCP_CPP_PROG="@cpp_simple@@cpp_simple_args@"
------------
In etc_init.d_pmie, there's a call to a variable
named IS_ON, which doesn't exist. After searhing a
little into all the available code, I found its
declaration in pmlogger.sh.
The correction is to add the following lines at the beginning
of etc_init.d_pmie:
if which chkconfig >/dev/null 2>&1 ; then
IS_ON=chkconfig
else
IS_ON=false
fi
------------
In etc_init.d_pmie, there's a call to MAIL, which is defined as
MAIL=/usr/sbin/Mail
The problem is that, at least on Debian, it is /usr/bin/Mail
The correction is to do exactly like in src/pmcd/rc_pcp,
that is:
MAIL=`which Mail`
------------
I added support for Debian packages by changing all of the
Makefiles to use a supplementary variable, named DESTDIR,
which is ONLY defined when compiling the package for Debian.
(it has no incidence if used anywhere else like redhat, or
just plain .tar.gz).
This variable is used in front of each destination directory,
to allow a different path than an absolute one.
After some discussion with Mark Goodwin and a lot of tests,
I came to the conclusion that it is not currently possible
to define some global variable by modifying the pcp.conf file.
The problem is that this file is used BOTH for installation,
and for later use, after installation. Moreover, some files
are generated from these variables. So if I put the temporary
paths I use for installation, I will get all wrong :-(
If SGI could backport the DESTDIR variable trick into the
official distribution of PCP, it would be really cool, and
ease the work of Debian maintainers (me :-)
For the debian package, the other thing which is different
from standard installation is the path to man and doc
directories which are /usr/share/doc and /usr/share/man, to
comply with the Debian standards (and FHS too, I guess).
All of the debian specific mods and all centralized in the
debian/ directory.
The debian pcp package I made includes all of the corrections
described above. It is available from
ftp://ftp.banquise.org/pub/debian/
(I uploaded the diff file too, against the original
distribution).
Thanks,
Luc
--
Luc Stepniewski <lstep@xxxxxxxxxxxx> <http://lstep.free.fr/>
Adequat - Securite, Linux Public key: <http://lstep.free.fr/pubkey.txt>
Key D93B2D2D fingerprint = 49 00 CC D1 69 03 E2 94 C8 78 ED 3C 75 89 A8 DE
|