pagg
[Top] [All Lists]

[patch] Minor PAGG attach/detach semantic change for 2.6.11

To: Erik Jacobson <erikj@xxxxxxxxxxxxxxxxxxxxxxx>
Subject: [patch] Minor PAGG attach/detach semantic change for 2.6.11
From: Kingsley Cheung <kingsley@xxxxxxxxxx>
Date: Fri, 17 Jun 2005 11:45:12 +1000
Cc: pagg@xxxxxxxxxxx, tonyt@xxxxxxxxxx
Sender: pagg-bounce@xxxxxxxxxxx
User-agent: Mutt/1.4.1i
Hi Erik,

While testing the propagation of pagg_attach errors to fork() I
noticed that the detach callback is called again for the client
responsible for the error.  Perhaps you may have a different opinion
on this, but IMHO this is unnecessary as the client passing the
failure error up should have already cleaned up any data in its pagg
structure during its attach callback.

I've atttached a patch that applies (with some fuzz) correctly to
2.6.11 that avoids this unncessary call to the client's detach
callback.  Please consider applying.

Thanks, 
-- 
                Kingsley

Attachment: pagg.patch
Description: Text document

<Prev in Thread] Current Thread [Next in Thread>