Re: [patch] Registration Check for Compulsory Hooks

[Erik Jacobson <erikj@xxxxxxxxxxxxxxxxxxxxxxx>]

Thank you for pointing this out.

Indeed.  If someone set up a pagg hook with attach set to null, the next
procss forked after the kernel module was loaded would cause a panic.

So I agree we should add your change.

I'll take care of this tomorrow.  Thanks!

Erik

On Mon, 8 Nov 2004, Kingsley Cheung wrote:

> Hi,
>
> I was reading through the linux-2.6.9-pagg.patch when I noticed that
> "init()", "exec()" are considered optional but "attach()" and
> "detach()" are compulsory.  If that is true, then would perhaps there
> should be checks during registration to ensure "attach()" and
> "detach()" are defined?
>
> An untested patch against Linux 2.6.5 (that section of code hasn't
> changed in 2.6.9) is attached.
>
> Thanks,
> --
>               Kingsley
>

--
Erik Jacobson - Linux System Software - Silicon Graphics - Eagan, Minnesota