Erik Jacobson wrote:
I've just been reading the "job" patch and would like to suggest that
the file include/linux/paggctl.h should be renamed
include/linux/jobctl.h as it is about control of the "job" PAGG client
rather than PAGG itself which is what its current name suggests.
Sounds good to me personally. I think I came up with the bad name.
It really is job talking to pagg but I agree the name is confusing.
I agree, jobctl.h is a less confusing name for that header file.
One issue is that it would require us to re-spin the job package as, at this
moment, it includes paggctl.h. If you look at the job package, it itself has
a header called 'jobctl.h' that defines how the ioctl is done. So it might
be confusing to have two jobctl.h headers (one in the kernel, one in
userland) but maybe we can come up with something else.
We may change the name of user land jobctl.h to something like
jobctl_internal.h.
I'll file a bug in SGI to have those file names changed.
Thanks,
--Limin
Limin is starting to take over the job side of things so I'll let her
comment and look in to the change. -Erik
--
Erik Jacobson - Linux System Software - Silicon Graphics - Eagan, Minnesota
|