Hi there. We don't have a public bug tracking system (at least not yet).
So I'm using our internal system. I filed this bug. If you're interested
in it, you'd need to use the LKML discussion as a guide to what I"m talking
about.
I plan on implementing these issues over the next couple days.
---------- Forwarded message ----------
Date: Fri, 7 May 2004 06:04:02 -0700 (PDT)
From: "erikj@xxxxxxx via BugWorks" <erikj@xxxxxxx>
Reply-To: sgi.bugs.snlinux@xxxxxxxxxxxxxxxxx
Subject: BUG 914213 - PAGG feedback III - final round from the recent LKML
discussion
View Incident: http://co-op.engr.sgi.com/BugWorks/query.cgi/914213
Status: open Priority: 2
Assigned Group: linux-acct Project: snlinux
Assigned Engineer: erikj Submitter: erikj
CC List: jlan limin Opened Date: 05/07/04
This is the hopefully final (and hardest) feedback round.
Some of the things to look at here include things I had trouble implementing
before and will probably need help with.
- There are two list_for_each's left in pagg.c. One I need to leave as-is,
one can be changed to list_for_each_entry - I just missed it last round
and didn't want to sneak it in after people had done reviews.
- braces around '_l' in INIT_PAGG_LIST - I just couldn't get that to work and
will need help.
- I did change the macro names as suggested, but it was also suggested to
change the macros to static inlines. I had trouble implementing this.
I got some suggestions but still had some trouble. I need to look further.
- It was commenting that the "Registering PAGG support for X" is too verbose
but I couldn't come up with a less verbose message that still made sense to
me. Suggestions welcome.
- Biggest Issue: LOCKING LOCKING LOCKING.... I fixed up locking some, but
Chris Wright and Christoph Hellwig have had suggestions. They wonder if I
can switch from semaphores to spinlocks. Robin Holt wasn't convinced this
was a good idea. However, having semaphores makes the code more complicated.
In any case, we need to look at Chris Wright's feedback on locking and
figure out what to do. We should look in to the same adjustments for JOB
where necessary.
|