Re: [ogl-sample] GLU's mipmap.c

[Craig Dunwoody <dunwoody@xxxxxxx>]

ARitger@xxxxxxxxxx writes:
> I've attached a patch to the file main/gfx/lib/glu/libutil/mipmap.c that
> addresses two issues:
> - relaxes argument checking for the gluBuildMipmaps routines 
> internalFormat argument; validating the internalFormat broke some
> extensions.  I suppose that you could add cases to the switch statement in
> isLegalInternalFormat(), but this check will just break some other future
> extension, and the error checking doesn't by anything because glTexImage*
> will just do the same check itself.
> - modified closestFit() to handle the GL_ARB_texture_cube_map extension.

Thanks very much for the patch.  I have checked it into the GLU CVS at
oss.sgi.com, along with manpage changes documenting the resulting
change in error behavior.

Modified Files:
    main/doc/man/manglu/standard/build1dmipmaplevels.gl
    main/doc/man/manglu/standard/build1dmipmaps.gl
    main/doc/man/manglu/standard/build2dmipmaplevels.gl
    main/doc/man/manglu/standard/build2dmipmaps.gl
    main/doc/man/manglu/standard/build3dmipmaplevels.gl
    main/doc/man/manglu/standard/build3dmipmaps.gl
    main/gfx/lib/glu/libutil/mipmap.c

I will work with the XFree86 folks to get this patch pulled into the
mirrored copy of the SGI GLU implementation that is now part of
XFree86.

Craig Dunwoody
dunwoody@xxxxxxx