| To: | Linus Torvalds <torvalds@xxxxxxxx> |
|---|---|
| Subject: | Re: [PATCH] forcedeth: fix random memory scribbling bug |
| From: | Manfred Spraul <manfred@xxxxxxxxxxxxxxxx> |
| Date: | Sat, 24 Dec 2005 20:56:00 +0100 |
| Cc: | Jeff Garzik <jgarzik@xxxxxxxxx>, Ayaz Abdulla <AAbdulla@xxxxxxxxxx>, Linux Kernel Mailing List <linux-kernel@xxxxxxxxxxxxxxx>, Netdev <netdev@xxxxxxxxxxx> |
| In-reply-to: | <Pine.LNX.4.64.0512241145520.14098@g5.osdl.org> |
| References: | <43AD4ADC.8050004@colorfullife.com> <Pine.LNX.4.64.0512241145520.14098@g5.osdl.org> |
| Sender: | netdev-bounce@xxxxxxxxxxx |
| User-agent: | Mozilla/5.0 (X11; U; Linux i686; fr-FR; rv:1.7.12) Gecko/20050923 Fedora/1.7.12-1.5.1 |
Linus Torvalds wrote: Of course, on the alloc path, it seems to add an additional "NV_RX_ALLOC_PAD" thing, so maybe the "end-data" thing makes sense.The problem is the pci_unmap_single() call that happens during nv_close() or the rx interrupt handler. I think it makes more sense to rely on fields in the individual skb instead of reading from np->rx_buf_sz. If np->rx_buf_sz changes inbetween, then we have a memory leak. -- Manfred |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: [PATCH] forcedeth: fix random memory scribbling bug, Linus Torvalds |
|---|---|
| Next by Date: | Re: [PATCH] forcedeth: fix random memory scribbling bug, Linus Torvalds |
| Previous by Thread: | Re: [PATCH] forcedeth: fix random memory scribbling bug, Linus Torvalds |
| Next by Thread: | Re: [PATCH] forcedeth: fix random memory scribbling bug, Linus Torvalds |
| Indexes: | [Date] [Thread] [Top] [All Lists] |