Re: [PATCH 2.4] sis900: come alive after temporary memory shortage

To:	Vasily Averin <vvs@xxxxx>
Subject:	Re: [PATCH 2.4] sis900: come alive after temporary memory shortage
From:	Marcelo Tosatti <marcelo.tosatti@xxxxxxxxxxxx>
Date:	Sun, 27 Nov 2005 06:35:15 -0200
Cc:	linux-kernel@xxxxxxxxxxxxxxx, Konstantin Khorenko <khorenko@xxxxx>, netdev@xxxxxxxxxxx, Daniele Venzano <venza@xxxxxxxxxxxx>
In-reply-to:	<438829AF.8060101@xxxxx>
References:	<438829AF.8060101@xxxxx>
Sender:	netdev-bounce@xxxxxxxxxxx
User-agent:	Mutt/1.5.5.1i

On Sat, Nov 26, 2005 at 12:23:59PM +0300, Vasily Averin wrote:
> Hello Marcelo,
> 
> I would like to inform you that unfortunately the committed patch is wrong
> http://www.kernel.org/git/?p=linux/kernel/git/marcelo/linux-2.4.git;a=commit;h=ecf3337f76eaa94c5a771308d184dc248b74b725
> 
> +     int rx_work_limit =
> +             (sis_priv->dirty_rx - sis_priv->cur_rx) % NUM_RX_DESC;
> 
> when dirty_rx = cur_rx it computes limit=0, but should be NUM_RX_DESC
> 
> Could you please drop the wrong patch and use a new one based on the version
> approved by Daniele Venzano and Jeff Garzik
> http://www.kernel.org/git/?p=linux/kernel/git/jgarzik/netdev-2.6.git;a=commitdiff_plain;h=7380a78a973a8109c13cb0e47617c456b6f6e1f5;hp=b2795f596932286ef12dc08857960d654f577405


Will do - thanks Vasily.

<Prev in Thread]	Current Thread	[Next in Thread>
[PATCH 2.4] sis900: come alive after temporary memory shortage, Vasily Averin Re: [PATCH 2.4] sis900: come alive after temporary memory shortage, Marcelo Tosatti <=

Previous by Date:	[PATCH 2.4] sis900: come alive after temporary memory shortage, Vasily Averin
Next by Date:	Re: VIA "Velocity" test report - VLAN reception not working, Francois Romieu
Previous by Thread:	[PATCH 2.4] sis900: come alive after temporary memory shortage, Vasily Averin
Next by Thread:	[PATCH] i82596/CONFIG_APRICOT release_region() fix, Magnus Damm
Indexes:	[Date] [Thread] [Top] [All Lists]