| To: | Ayaz Abdulla <aabdulla@xxxxxxxxxx> |
|---|---|
| Subject: | Re: [PATCH 2/2] forcedeth: scatter gather and segmentation offload support |
| From: | Jeff Garzik <jgarzik@xxxxxxxxx> |
| Date: | Wed, 26 Oct 2005 00:53:09 -0400 |
| Cc: | Stephen Hemminger <shemminger@xxxxxxxx>, Manfred Spraul <manfred@xxxxxxxxxxxxxxxx>, Netdev <netdev@xxxxxxxxxxx> |
| In-reply-to: | <435D1464.3010203@xxxxxxxxxx> |
| References: | <432D7354.8000503@xxxxxxxxxxxxxxxx> <43595C42.4080201@xxxxxxxxx> <435D1047.2070401@xxxxxxxxxx> <20051024110003.53e37edd@xxxxxxxxxxxxxxxxx> <435D1464.3010203@xxxxxxxxxx> |
| Sender: | netdev-bounce@xxxxxxxxxxx |
| User-agent: | Mozilla Thunderbird 1.0.7-1.1.fc4 (X11/20050929) |
Ayaz Abdulla wrote: Yes, forgot that indent. Here it is again with that fix. I applied this version of the patch to the 'upstream' patch.In the future, as Stephen noted, it would really be preferred that you split up the patch into logical changes. patch 1/2 netdev_priv(), patch 2/2 SG support, for example.
Also, always include the Signed-off-by line, even on patch resends. See
http://linux.yyz.us/patch-format.html
for more info.
Jeff
|
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: [PATCH 2/2] forcedeth: scatter gather and segmentation offload support, Michael Chan |
|---|---|
| Next by Date: | RE: [PATCH 2/2] forcedeth: scatter gather and segmentation offload support, Ayaz Abdulla |
| Previous by Thread: | Re: [PATCH 2/2] forcedeth: scatter gather and segmentation offload support, Ayaz Abdulla |
| Next by Thread: | Re: [PATCH 2/2] forcedeth: scatter gather and segmentation offload support, Stephen Hemminger |
| Indexes: | [Date] [Thread] [Top] [All Lists] |