netdev
[Top] [All Lists]

Re: skge: reboot on sysfs resource0 access

To: Stephen Hemminger <shemminger@xxxxxxxx>
Subject: Re: skge: reboot on sysfs resource0 access
From: Ben Greear <greearb@xxxxxxxxxxxxxxx>
Date: Fri, 09 Sep 2005 11:21:52 -0700
Cc: bernd-schubert@xxxxxx, bernd.schubert@xxxxxxxxxxxxxxxxxxxxx, netdev@xxxxxxxxxxx
In-reply-to: <20050909110153.5a2e2e90@xxxxxxxxxxxxxxxxxxxxx>
Organization: Candela Technologies
References: <200509091938.18079.bernd.schubert@xxxxxxxxxxxxxxxxxxxxx> <20050909110153.5a2e2e90@xxxxxxxxxxxxxxxxxxxxx>
Sender: netdev-bounce@xxxxxxxxxxx
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.7.10) Gecko/20050719 Fedora/1.7.10-1.3.1
Stephen Hemminger wrote:
On Fri, 9 Sep 2005 19:38:17 +0200
Bernd Schubert <bernd.schubert@xxxxxxxxxxxxxxxxxxxxx> wrote:


Hello,

today we tried 2.6.13 on our server and also tried to use the skge driver. Well, in principle it works fine, until I became curious about the sysfs values. Stupid me, I was using the midnight commander to read the values. When I opened "/sys/bus/pci/drivers/skge/0000:01:01.0/resource0", the system immediately rebooted. After the reboot we tested using cat to the resource0 file, which gave an input/output error. Using again the mc, the system again immediately rebooted. Well, I guess I better don't use the midnight commander in the future, but somehow I think it shouldn't cause the system to reboot, should it? Is the i/o error of cat supposed to happen?



Don't do that!  resource0 is the pci space for the card and
reading it directly accesses the memory mapped space. The
register is sparse, and some places are unaccessable. Accessing non-existent memory will cause system to hang and if you
are lucky a timeout and reboot.

Sorry, this is not a driver bug.

Does that mean if you do this:

find /sys -name "*" -print|xargs grep foo

that the system will crash?

I certainly would consider that a bug, and even if that somehow works, I'd
think that at the least you should be able to read every file in the file
system without crashing the system!

Do you at least have to be root to cause this crash?

Ben

--
Ben Greear <greearb@xxxxxxxxxxxxxxx>
Candela Technologies Inc  http://www.candelatech.com


<Prev in Thread] Current Thread [Next in Thread>