netdev
[Top] [All Lists]

Re: Strange uses of netif_start_queue

To: Alan Cox <alan@xxxxxxxxxxxxxxxxxxx>
Subject: Re: Strange uses of netif_start_queue
From: Ralf Baechle <ralf@xxxxxxxxxxxxxx>
Date: Fri, 12 Aug 2005 14:39:05 +0100
Cc: netdev@xxxxxxxxxxx
In-reply-to: <20050812132758.GE2819@xxxxxxxxxxxxxx>
References: <1123853714.22460.39.camel@xxxxxxxxxxxxxxxxxxxxx> <20050812132758.GE2819@xxxxxxxxxxxxxx>
Sender: netdev-bounce@xxxxxxxxxxx
User-agent: Mutt/1.4.2.1i
On Fri, Aug 12, 2005 at 02:27:59PM +0100, Ralf Baechle wrote:

> > Something I noticed doing the tty work. the 6pack driver calls
> > netif_start_queue() before it calls register_netdev. I'm curious if this
> > is allowed ?
> 
> As part of adding support for extended 6pack which is required by the
> PR 430 I've recently fixed that.  It was looking suspect enough that I
> fixed it though I don't see any way this could do harm.

To answer the fundamental question, I think netif_start_queue /
netif_stop_queue should be allowed in case the driver for some reason has
the desire to stop queueing of packet immediately after register_netdev.

  Ralf

<Prev in Thread] Current Thread [Next in Thread>