netdev
[Top] [All Lists]

Re: [PATCH 2.6.12.1 5/12] S2io: Performance improvements

To: "David S. Miller" <davem@xxxxxxxxxxxxx>, raghavendra.koushik@xxxxxxxxxxxx
Subject: Re: [PATCH 2.6.12.1 5/12] S2io: Performance improvements
From: Jeff Garzik <jgarzik@xxxxxxxxx>
Date: Thu, 07 Jul 2005 23:08:02 -0400
Cc: akepner@xxxxxxx, netdev@xxxxxxxxxxx, netdev@xxxxxxxxxxxxxxx, ravinandan.arakali@xxxxxxxxxxxx, leonid.grossman@xxxxxxxxxxxx, rapuru.sriram@xxxxxxxxxxxx
In-reply-to: <20050707.200034.74747399.davem@xxxxxxxxxxxxx>
References: <Pine.LNX.4.61.0507071552130.24321@xxxxxxxxxxxxxxxxxxx> <200507080106.j6816NKP022996@xxxxxxxxxxxxxxxxx> <20050707.200034.74747399.davem@xxxxxxxxxxxxx>
Sender: netdev-bounce@xxxxxxxxxxx
User-agent: Mozilla Thunderbird 1.0.2-6 (X11/20050513)
David S. Miller wrote:
If you need a PIO to complete in a specific order, you
have to read it back.  If you need PIO operations to occur

Correct.

A PCI read is the only way to ensure that all the CPU/PCI bridge buffers are flushed to the device.

Whenever Arjan and I complain about "PCI posting" problems, we are indicating a need for additional readl() calls to ensure ordering/flushing. Delaying immediately after a writel() is a classic PCI posting mistake. Assuming ordering is another.

        Jeff



<Prev in Thread] Current Thread [Next in Thread>