netdev
[Top] [All Lists]

Re: [PATCH 1/8][ATM]: [zatm] eliminate kfree warning (from Tobias Hirnin

To: chas williams - CONTRACTOR <chas@xxxxxxxxxxxxxxxx>
Subject: Re: [PATCH 1/8][ATM]: [zatm] eliminate kfree warning (from Tobias Hirning <sskyman@web.de>)
From: Francois Romieu <romieu@xxxxxxxxxxxxx>
Date: Wed, 20 Jul 2005 00:31:34 +0200
Cc: netdev@xxxxxxxxxxx, davem@xxxxxxxxxxxxx
In-reply-to: <200507192044.j6JKirFb027183@ginger.cmf.nrl.navy.mil>
References: <200507192044.j6JKirFb027183@ginger.cmf.nrl.navy.mil>
Sender: netdev-bounce@xxxxxxxxxxx
User-agent: Mutt/1.4.2.1i
chas williams - CONTRACTOR <chas@xxxxxxxxxxxxxxxx> :
[...]
> diff --git a/drivers/atm/zatm.c b/drivers/atm/zatm.c
> --- a/drivers/atm/zatm.c
> +++ b/drivers/atm/zatm.c
> @@ -1339,7 +1339,7 @@ static int __init zatm_start(struct atm_
>       return 0;
>      out:
>       for (i = 0; i < NR_MBX; i++)
> -             kfree(zatm_dev->mbx_start[i]);
> +             kfree(&zatm_dev->mbx_start[i]);
>       kfree(zatm_dev->rx_map);
>       kfree(zatm_dev->tx_map);
>       free_irq(zatm_dev->irq, dev);

Wow...

static int __init zatm_start(struct atm_dev *dev)
{
[...]
        for (i = 0; i < NR_MBX; i++)
[blah blah]
                        here = (unsigned long) kmalloc(2*MBX_SIZE(i),
                            GFP_KERNEL);
[blah blah]
                        zatm_dev->mbx_start[i] = here;

There is some stuff in my patchbucket for this one, please wait a minute.

--
Ueimor

<Prev in Thread] Current Thread [Next in Thread>