netdev
[Top] [All Lists]

Re: [PATCH] fix small DoS on connect() (was Re: BUG: Unusual TCP Connect

To: Willy Tarreau <willy@xxxxxxxxx>
Subject: Re: [PATCH] fix small DoS on connect() (was Re: BUG: Unusual TCP Connect() results.)
From: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>
Date: Mon, 13 Jun 2005 17:45:21 +1000
Cc: davem@xxxxxxxxxxxxx, xschmi00@xxxxxxxxxxxxxxxxxx, alastair@xxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, netdev@xxxxxxxxxxx
In-reply-to: <20050613061748.GA13144@xxxxxxxxxxxxxxxx>
References: <20050612123253.GK28759@xxxxxxxxxxxxxxxx> <20050612131323.GA10188@xxxxxxxxxxxxxxxxxxx> <20050612133349.GA6279@xxxxxxxxxxxxxxxxxxx> <20050612134725.GB8951@xxxxxxxxxxxxxxxx> <20050612135018.GA10910@xxxxxxxxxxxxxxxxxxx> <20050612142401.GA10772@xxxxxxxxxxxxxxxx> <20050613044810.GA32103@xxxxxxxxxxxxxxxxxxx> <20050613052148.GF8907@xxxxxxxxxxxxxxxx> <20050613052404.GA7611@xxxxxxxxxxxxxxxxxxx> <20050613061748.GA13144@xxxxxxxxxxxxxxxx>
Sender: netdev-bounce@xxxxxxxxxxx
User-agent: Mutt/1.5.9i
On Mon, Jun 13, 2005 at 08:17:48AM +0200, Willy Tarreau wrote:
> 
> What's the problem with the sysctl ? If you prefer, I can change the patch
> to keep the feature enabled by default so that only people aware of the
> problem have to fix it by hand. But I found it better the other way : people
> who need the feature enable it by hand.

Well that's exactly my problem :)

I reckon it should be off by default because the threat posed by
this problem is IMHO small compared to some of the other standard
threats that are applicable to TCP.  Plus this is a well-documented
feature so we can't be sure that someone somewhere isn't depending
on it.

However, if it were off by default then there is very little value
in providing it at all since the same thing can be achived easily
through netfilter.

Anyway, let's leave it to Dave to make the decision.

Cheers,
-- 
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@xxxxxxxxxxxxxxxxxxx>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

<Prev in Thread] Current Thread [Next in Thread>