netdev
[Top] [All Lists]

Re: IPV6 RFC3542 compliance [PATCH]

To: YOSHIFUJI Hideaki / 吉藤英明 <yoshfuji@xxxxxxxxxxxxxx>
Subject: Re: IPV6 RFC3542 compliance [PATCH]
From: David Stevens <dlstevens@xxxxxxxxxx>
Date: Tue, 7 Jun 2005 01:04:17 -0700
Cc: davem@xxxxxxxxxxxxx, netdev@xxxxxxxxxxx, yoshfuji@xxxxxxxxxxxxxx
In-reply-to: <20050607.165536.75463878.yoshfuji@xxxxxxxxxxxxxx>
Sender: netdev-bounce@xxxxxxxxxxx
YOSHIFUJI Hideaki / 吉藤英明 <yoshfuji@xxxxxxxxxxxxxx> wrote on 06/07/2005 
12:55:36 AM:

> In article <20050607.164749.62298775.yoshfuji@xxxxxxxxxxxxxx> (at Tue, 
07 Jun 
> 2005 16:47:49 +0900 (JST)), YOSHIFUJI Hideaki / 吉藤英明 
<yoshfuji@xxxxxxxxxxxxxx> says:

> > No, kernel should send 5, if application use old API, of course.

> This can be implemented like this (based on codes from our repository):

> /* RFC2292bis */
> if (np->rxopt.bits.rxhbh && opt->hop) {
> u8 *ptr = skb->nh.raw + opt->hop;
> put_cmsg(msg, SOL_IPV6, IPV6_HOPOPTS, (ptr[1]+1)<<3, ptr);
> }
> /* RFC2292 */
> if (np->rxopt.bits.rxhbh2292 && opt->hop) {
> u8 *ptr = skb->nh.raw + opt->hop;
> put_cmsg(msg, SOL_IPV6, IPV6_2292HOPOPTS, (ptr[1]+1)<<3, ptr);
> }

> --yoshfuji

Sure, it's easy to do. But the application that's using
it has broken source, and nobody will know until after it's
recompiled.

I'd just have a single flag for all, on the assumption that
they're either using old API exclusively, or new. But, again,
it leaves a land mine for the source bug in the application
that you're allowing to still work.

                                                +-DLS


<Prev in Thread] Current Thread [Next in Thread>