[Top] [All Lists]

Re: [RFC] Replace scatterlist with crypto_frag

To: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>
Subject: Re: [RFC] Replace scatterlist with crypto_frag
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Mon, 6 Jun 2005 14:30:22 +0100
Cc: Christoph Hellwig <hch@xxxxxxxxxxxxx>, "David S. Miller" <davem@xxxxxxxxxxxxx>, James Morris <jmorris@xxxxxxxxxx>, Linux Crypto Mailing List <linux-crypto@xxxxxxxxxxxxxxx>, netdev@xxxxxxxxxxx
In-reply-to: <20050606124043.GA625@xxxxxxxxxxxxxxxxxxx>
References: <20050603234623.GA20088@xxxxxxxxxxxxxxxxxxx> <20050604112314.GA19819@xxxxxxxxxxxxx> <20050604112606.GA1799@xxxxxxxxxxxxxxxxxxx> <20050604115853.GA20335@xxxxxxxxxxxxx> <20050606115939.GA399@xxxxxxxxxxxxxxxxxxx> <20050606120914.GA8317@xxxxxxxxxxxxx> <20050606124043.GA625@xxxxxxxxxxxxxxxxxxx>
Sender: netdev-bounce@xxxxxxxxxxx
User-agent: Mutt/1.4.1i
On Mon, Jun 06, 2005 at 10:40:43PM +1000, Herbert Xu wrote:
> On Mon, Jun 06, 2005 at 01:09:14PM +0100, Christoph Hellwig wrote:
> >
> > > #if (PAGE_SHIFT > 16) || (BITS_PER_LONG > 32)
> > 
> > what is the BITS_PER_LONG check for?
> These structures are normally used in arrays.  On a 64-bit machine
> the alignment requirement means that the 16-bit version will be
> padded to have the same length as the 32-bit version.  Since 32-bit
> access is usually faster we might as well get it for free.

At this point it might be easiest to just say the architecture must
declare the type in asm/types.h

<Prev in Thread] Current Thread [Next in Thread>