Re: [RFC] Replace scatterlist with crypto_frag

[Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>]

On Sat, Jun 04, 2005 at 12:23:14PM +0100, Christoph Hellwig wrote:
> On Sat, Jun 04, 2005 at 09:46:23AM +1000, Herbert Xu wrote:
> > struct crypto_frag {
> >     struct page *page;
> >     u16 offset;
> >     u16 length;
> > };
> 
> we have this structure as skb_frag_struct and bio_vec already, care
> to use the same structure with a generic name for all of them?

I certainly would have no problems merging with skb_frag_struct.
However, merging with bio_vec would mean that either bio_vec would
have to drop down to 16-bit counters, or crypto_frag would have to
move up to 32-bit counters.

The latter is problematic because I'm trying to shrink the size
enough so that we can squeeze four of these things onto the stack.

Cheers,
-- 
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@xxxxxxxxxxxxxxxxxxx>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt