| To: | "Ronciak, John" <john.ronciak@xxxxxxxxx> |
|---|---|
| Subject: | RE: RFC: NAPI packet weighting patch |
| From: | Robert Olsson <Robert.Olsson@xxxxxxxxxxx> |
| Date: | Fri, 3 Jun 2005 22:17:31 +0200 |
| Cc: | "Robert Olsson" <Robert.Olsson@xxxxxxxxxxx>, "David S. Miller" <davem@xxxxxxxxxxxxx>, <jdmason@xxxxxxxxxx>, <shemminger@xxxxxxxx>, <hadi@xxxxxxxxxx>, "Williams, Mitch A" <mitch.a.williams@xxxxxxxxx>, <netdev@xxxxxxxxxxx>, "Venkatesan, Ganesh" <ganesh.venkatesan@xxxxxxxxx>, "Brandeburg, Jesse" <jesse.brandeburg@xxxxxxxxx> |
| In-reply-to: | <468F3FDA28AA87429AD807992E22D07E0450BFE8@orsmsx408> |
| References: | <468F3FDA28AA87429AD807992E22D07E0450BFE8@orsmsx408> |
| Sender: | netdev-bounce@xxxxxxxxxxx |
Ronciak, John writes:
> With the same system (fairly high end with nothing major running on it)
> we got rid of the dropped frames by just reducing the weight for 64. So
> the weight did have something to do with the dropped frames. Maybe
> other factors as well, but in static tests like this it sure looks like
> the 64 value is wrong is some cases.
It is possible that a lower weight forced your driver to disable interrupts
and do packet reception w/o interrupts often this is more efficient as
we get rid intr. latency etc.
Again I think weight should only used for fairness and not control the
threshold when to disable interrupts.
You can test with a new policy in e1000_clean so you schedule for a new
poll if work_done (any pkts received) or tx_cleaned is true.
Cheers.
--ro
|
| Previous by Date: | Re: RFC: NAPI packet weighting patch, jamal |
|---|---|
| Next by Date: | Re: RFC: NAPI packet weighting patch, David S. Miller |
| Previous by Thread: | Re: RFC: NAPI packet weighting patch, David S. Miller |
| Next by Thread: | Re: RFC: NAPI packet weighting patch, David S. Miller |
| Indexes: | [Date] [Thread] [Top] [All Lists] |