| To: | "David S. Miller" <davem@xxxxxxxxxxxxx> |
|---|---|
| Subject: | RE: RFC: NAPI packet weighting patch |
| From: | "Ronciak, John" <john.ronciak@xxxxxxxxx> |
| Date: | Fri, 3 Jun 2005 10:40:47 -0700 |
| Cc: | <jdmason@xxxxxxxxxx>, <shemminger@xxxxxxxx>, <hadi@xxxxxxxxxx>, "Williams, Mitch A" <mitch.a.williams@xxxxxxxxx>, <netdev@xxxxxxxxxxx>, <Robert.Olsson@xxxxxxxxxxx>, "Venkatesan, Ganesh" <ganesh.venkatesan@xxxxxxxxx>, "Brandeburg, Jesse" <jesse.brandeburg@xxxxxxxxx> |
| Sender: | netdev-bounce@xxxxxxxxxxx |
| Thread-index: | AcVn0fHLt/WdosjHQo2U4D6fkFIrvwAkDmig |
| Thread-topic: | RFC: NAPI packet weighting patch |
> What more do you need other than checking the statistics counter? The > drop statistics (the ones we care about) are incremented in real time > by the ->poll() code, so it's not like we have to trigger some > asynchronous event to get a current version of the number. > I think that there is some more confusion here. I'm talking about frames dropped by the Ethernet controller at the hardware level (no descriptor available). This for example is happening now with our driver with the weight set to 64. This is also what started us looking into what was going on with the weight. I don't see how the NAPI code to dynamically adjust the weight could easily get the hardware stats number to know if frames are being dropped or not. Sorry if I caused the confusion here. Mitch is working on a response to Jamal's last mail trying to level set what we are seeing and doing. Cheers, John |
| Previous by Date: | [9/9] ieee80211: ETH_P_802_11 ethertype, Jiri Benc |
|---|---|
| Next by Date: | Re: RFC: NAPI packet weighting patch, Mitch Williams |
| Previous by Thread: | Re: RFC: NAPI packet weighting patch, Mitch Williams |
| Next by Thread: | RE: RFC: NAPI packet weighting patch, Robert Olsson |
| Indexes: | [Date] [Thread] [Top] [All Lists] |