netdev
[Top] [All Lists]

Re: [PATCH] NUMA aware allocation of transmit and receive buffers for e1

To: Christoph Lameter <christoph@xxxxxxxxxxx>
Subject: Re: [PATCH] NUMA aware allocation of transmit and receive buffers for e1000
From: Andi Kleen <ak@xxxxxx>
Date: 30 May 2005 11:41:07 +0200
Date: Mon, 30 May 2005 11:41:07 +0200
Cc: Eric Dumazet <dada1@xxxxxxxxxxxxx>, netdev@xxxxxxxxxxx, akpm@xxxxxxxx, shai@xxxxxxxxxxxx
In-reply-to: <Pine.LNX.4.62.0505271413560.25484@xxxxxxxxxx>
References: <Pine.LNX.4.62.0505171854490.20408@xxxxxxxxxx> <m1sm0l5lwa.fsf@xxxxxx> <428AF378.5020109@xxxxxxxxxxxxx> <Pine.LNX.4.62.0505271413560.25484@xxxxxxxxxx>
Sender: netdev-bounce@xxxxxxxxxxx
User-agent: Mutt/1.4.1i
On Fri, May 27, 2005 at 02:15:55PM -0700, Christoph Lameter wrote:
> On Wed, 18 May 2005, Eric Dumazet wrote:
> 
> > Related question, is pci_alloc_consistent() already NUMA aware ?
> 
> Nope. It also ultimately acquires memory via vmalloc.

x86-64 vmalloc has been NUMA aware forever.
I believe the HP BigTux patchkit for IA64 added it there too, although
it might not have hit mainline.

> 
> pci_alloc_consistent will also need some rework to allocate memory 
> consistent (well the name is coherent right?) with the node that the 
> device is on. Second case of a need for a node aware vmalloc?

You can already have it today by temporarily changing the process
mempolicy. However for pci_alloc_consistent just using alloc_pages_node
directly seems to work fine. 

-Andi

<Prev in Thread] Current Thread [Next in Thread>