Re: [PATCH] r8169: support restricting speed+duplex in autonegotiation

[Richard Dawe <rich@xxxxxxxxxxxxxxxxxxxx>]

Hello.

Francois Romieu wrote:
> Richard Dawe <rich@xxxxxxxxxxxxxxxxxxxx> :
> [...]
>
> > This particular code is to support the "media" option for the r8169 
> > module. The "media" option is marked as deprecated in favour of ethtool.
>
> The current code is supposed to provide via ethtool the same function that
> the media option did in Realtek's version of the driver (i.e. mostly a
> current 'ethtool -s ethX autoneg off speed foo duplex bar').
AFAICS the current r8169 driver always autonegotiates in xMII mode.

> Afaik, neither in Realtek's code nor in the current in-kernel driver does
> the (obsolescent) "media" code do what one would expect from a "media"
> option.
My patch doesn't change the behaviour of the "media" option.

Is the "media" part of the patch confusing?

Bye, Rich =]

--
Richard Dawe [ http://homepages.nildram.co.uk/~phekda/richdawe/ ]

"You can't evaluate a man by logic alone."
  -- McCoy, "I, Mudd", Star Trek