Re: [PATCH] e1000: NUMA aware allocation of descriptors V2

To:	Christoph Lameter <christoph@xxxxxxxxxxx>
Subject:	Re: [PATCH] e1000: NUMA aware allocation of descriptors V2
From:	Andrew Morton <akpm@xxxxxxxx>
Date:	Fri, 27 May 2005 16:25:28 -0700
Cc:	ganesh.venkatesan@xxxxxxxxx, davem@xxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, netdev@xxxxxxxxxxx, shai@xxxxxxxxxxxx
In-reply-to:	<Pine.LNX.4.62.0505271450200.25909@xxxxxxxxxx>
References:	<Pine.LNX.4.62.0505171854490.20408@xxxxxxxxxx> <20050517190343.2e57fdd7.akpm@xxxxxxxx> <Pine.LNX.4.62.0505171941340.21153@xxxxxxxxxx> <20050517.195703.104034854.davem@xxxxxxxxxxxxx> <Pine.LNX.4.62.0505172125210.22920@xxxxxxxxxx> <20050517215845.2f87be2f.akpm@xxxxxxxx> <5fc59ff305051808558f1ce59@xxxxxxxxxxxxxx> <20050518134250.3ee2703f.akpm@xxxxxxxx> <Pine.LNX.4.62.0505271450200.25909@xxxxxxxxxx>
Sender:	netdev-bounce@xxxxxxxxxxx

Christoph Lameter <christoph@xxxxxxxxxxx> wrote:
>
> NUMA awareness for the e1000 driver. Allocate tx and rx descriptors
> on the node of the device.
> 
> It is safe to replace vmalloc by kmalloc node since only the descriptors
> are allocated in a NUMA aware way. These will not be so large that the
> use of vmalloc becomes necesssary.

Really?  That's probably OK with the default number of tx descriptors, but
that number can be made arbitrarily large with a module parameter.

Could you please work this with the e1000 developers?

<Prev in Thread]	Current Thread	[Next in Thread>
[PATCH] NUMA aware allocation of transmit and receive buffers for e1000, Christoph Lameter Re: [PATCH] NUMA aware allocation of transmit and receive buffers for e1000, Andrew Morton Re: [PATCH] NUMA aware allocation of transmit and receive buffers for e1000, Christoph Lameter Re: [PATCH] NUMA aware allocation of transmit and receive buffers for e1000, David S. Miller Re: [PATCH] NUMA aware allocation of transmit and receive buffers for e1000, Christoph Lameter Re: [PATCH] NUMA aware allocation of transmit and receive buffers for e1000, Andrew Morton Re: [PATCH] NUMA aware allocation of transmit and receive buffers for e1000, Ganesh Venkatesan Re: [PATCH] NUMA aware allocation of transmit and receive buffers for e1000, Andrew Morton [PATCH] e1000: NUMA aware allocation of descriptors V2, Christoph Lameter Re: [PATCH] e1000: NUMA aware allocation of descriptors V2, Andrew Morton <= Re: [PATCH] NUMA aware allocation of transmit and receive buffers for e1000, Andi Kleen Re: [PATCH] NUMA aware allocation of transmit and receive buffers for e1000, Andi Kleen Re: [PATCH] NUMA aware allocation of transmit and receive buffers for e1000, Eric Dumazet Re: [PATCH] NUMA aware allocation of transmit and receive buffers for e1000, Andi Kleen Re: [PATCH] NUMA aware allocation of transmit and receive buffers for e1000, Christoph Lameter Re: [PATCH] NUMA aware allocation of transmit and receive buffers for e1000, Andi Kleen

Previous by Date:	[PATCH 5/5] [PKT_SCHED] textsearch ematch, Thomas Graf
Next by Date:	[IPSEC] Add XFRMA_SA/XFRMA_POLICY for delete notification, Herbert Xu
Previous by Thread:	[PATCH] e1000: NUMA aware allocation of descriptors V2, Christoph Lameter
Next by Thread:	Re: [PATCH] NUMA aware allocation of transmit and receive buffers for e1000, Andi Kleen
Indexes:	[Date] [Thread] [Top] [All Lists]