Re: RFC: NAPI packet weighting patch

[Stephen Hemminger <shemminger@xxxxxxxx>]

On Fri, 27 May 2005 13:27:04 -0700
Mitch Williams <mitch.a.williams@xxxxxxxxx> wrote:

> 
> Stephen, Robert, and Jamal all replied to my original message, and all
> said approximately the same thing:  "Why don't you just reduce the weight
> in the driver?  It does the same thing."
> 
> To which I reply, respectfully, I know that.  And no it doesn't, not
> exactly.
> 
> My primary reason for adding this setting is to allow for runtime tweaking
> -- just like max_backlog has right now.  Driver weight is a compile-time
> setting, and has to be changed for every driver that you run.
> 
> This setting allows you to scale the weight of all your drivers, at
> runtime, in one place.  It's complimentary to Stephen's max_weight idea --
> his patch affects how long you spend in any individual softirq; my patch
> affects how long you spend in any driver's individual NAPI poll routine,
> as well as how long the softirq lasts.
>

Why not just allow adjusting dev->weight via sysfs?