| To: | Michael Chan <mchan@xxxxxxxxxxxx> |
|---|---|
| Subject: | Re: A new driver for Broadcom bcm5706 |
| From: | Christoph Hellwig <hch@xxxxxxxxxxxxx> |
| Date: | Fri, 27 May 2005 18:15:32 +0100 |
| Cc: | Christoph Hellwig <hch@xxxxxxxxxxxxx>, davem@xxxxxxxxxxxxx, jgarzik@xxxxxxxxxx, netdev@xxxxxxxxxxx, ffan@xxxxxxxxxxxx, lusinsky@xxxxxxxxxxxx |
| In-reply-to: | <1117209503.4584.11.camel@rh4> |
| References: | <1116609329.31523.16.camel@rh4> <20050527074115.GA28208@xxxxxxxxxxxxx> <1117209503.4584.11.camel@rh4> |
| Sender: | netdev-bounce@xxxxxxxxxxx |
| User-agent: | Mutt/1.4.1i |
On Fri, May 27, 2005 at 08:58:23AM -0700, Michael Chan wrote: > > These defintions overlap older 10MB/s defintions. I don't think the number > > space is scare enough to need this hack. If we absolutely want to keep it > > you should at least add some big comments explaining it. > > > > > Yes they do. But these overlapping bit definitions are defined by the > 802.3 standard for 1000Base-X. These are not Broadcom proprietary > definitions. Ok, makes a lot of sense. Now just mention that in a nice comment in ethtool.h :) |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | [PATCH 2/2] [NETLINK] Correctly set NLM_F_MULTI without checking the pid, Thomas Graf |
|---|---|
| Next by Date: | [patch 2.6.12-rc5] tg3: add bcm5752 entry to pci.ids, John W. Linville |
| Previous by Thread: | Re: A new driver for Broadcom bcm5706, Michael Chan |
| Next by Thread: | [PATCH] Super TSO v2, David S. Miller |
| Indexes: | [Date] [Thread] [Top] [All Lists] |