netdev
[Top] [All Lists]

Re: PATCH: rtnetlink explicit flags setting

To: jamal <hadi@xxxxxxxxxx>
Subject: Re: PATCH: rtnetlink explicit flags setting
From: Thomas Graf <tgraf@xxxxxxx>
Date: Fri, 27 May 2005 18:59:35 +0200
Cc: "David S. Miller" <davem@xxxxxxxxxxxxx>, netdev@xxxxxxxxxxx
In-reply-to: <1117209466.6383.106.camel@xxxxxxxxxxxxxxxxxxxxx>
References: <1117197157.6688.24.camel@xxxxxxxxxxxxxxxxxxxxx> <20050527125010.GO15391@xxxxxxxxxxxxxx> <1117202331.6383.39.camel@xxxxxxxxxxxxxxxxxxxxx> <20050527141320.GQ15391@xxxxxxxxxxxxxx> <1117206091.6383.73.camel@xxxxxxxxxxxxxxxxxxxxx> <20050527151913.GA15391@xxxxxxxxxxxxxx> <1117209466.6383.106.camel@xxxxxxxxxxxxxxxxxxxxx>
Sender: netdev-bounce@xxxxxxxxxxx
* jamal <1117209466.6383.106.camel@xxxxxxxxxxxxxxxxxxxxx> 2005-05-27 11:57
> On Fri, 2005-27-05 at 17:19 +0200, Thomas Graf wrote:
> 
> > Sure, I can come up with a patchset today which will include:
> >  o the new NLMSG_NEW macro
> >  o your patch adopted to use the new NLMSG_NEW macro
> >  o small patch to rename NLMSG_PUT_ANSWER usages into NLMSG_NEW_ANSWER
> >  o a small fallout from the new neighbour table code which gcc didn't
> >    warn me about when it should.
> > 
> > OK?
> 
> Sounds reasonable.

I took your patch, converted it to use NLMSG_NEW and finished
converting all the modules that you started. Yet unconverted
are: netfilter, net/sched/ tcp_diag, xfrm, kernel/audit.

I also fixed some uses of NL_CREDS() to fetch the pid for
message generation which is wrong. Various dumping procedures
did not set the multi flag at all, I fixed all of them.

Do not apply these patches yet, they're way too intrusive

<Prev in Thread] Current Thread [Next in Thread>