Re: [PATCH 2.6] fix deadlock with ip_queue and tcp local input path

[Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>]

Harald Welte <laforge@xxxxxxxxxxxxx> wrote:
> 
> The patch below adds an additional queue for ip_queue verdicts.  They
> come up from userspace, are appended to a queue which is then processed
> by a tasklet.  The tasklet itself runs in softirq context, so when timer
> hardirq leaves, no tcp_delack_timer() will be executed until
> nf_reinject() has finished.

This seems to be overly complicated if all you want is to do this in
softirq context.  What's wrong with simply alling local_bh_disable?
-- 
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@xxxxxxxxxxxxxxxxxxx>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt