netdev
[Top] [All Lists]

Re: [PATCH] : bug fix in multipath drr code.

To: pravin b shelar <pravins@xxxxxxxxxxxxxx>
Subject: Re: [PATCH] : bug fix in multipath drr code.
From: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>
Date: Tue, 24 May 2005 17:11:46 +1000
Cc: netdev@xxxxxxxxxxx, "David S. Miller" <davem@xxxxxxxxxxxxx>
In-reply-to: <4292CDCE.2090600@xxxxxxxxxxxxxx>
References: <4291CBFF.6080106@xxxxxxxxxxxxxx> <20050523232224.GA25349@xxxxxxxxxxxxxxxxxxx> <4292CDCE.2090600@xxxxxxxxxxxxxx>
Sender: netdev-bounce@xxxxxxxxxxx
User-agent: Mutt/1.5.9i
On Tue, May 24, 2005 at 12:16:38PM +0530, pravin b shelar wrote:
>
> >The multipath_comparekeys isn't necessary either.
>
> In concurrent invocations of drr_select_route() last_selection will
> change to different route.
> So in that case we can not  use last_selection route on basis of
> FLOWI_FLAG_MULTIPATHOLDROUTE flag only, since old
> route might be totally different due another invocation of same function.
> So, I think multipath_comparekeys is necessary.

Indeed.  In fact this whole MULTIPATHOLDROUTE thing can't possibly
work at all.  I'd suggest that it be removed.

Cheers,
-- 
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@xxxxxxxxxxxxxxxxxxx>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

<Prev in Thread] Current Thread [Next in Thread>