netdev
[Top] [All Lists]

Re: A new driver for Broadcom bcm5706

To: "Jeff Garzik" <jgarzik@xxxxxxxxx>
Subject: Re: A new driver for Broadcom bcm5706
From: "Michael Chan" <mchan@xxxxxxxxxxxx>
Date: Fri, 20 May 2005 16:11:07 -0700
Cc: "David S.Miller" <davem@xxxxxxxxxxxxx>, netdev@xxxxxxxxxxx, ffan@xxxxxxxxxxxx, lusinsky@xxxxxxxxxxxx
In-reply-to: <428E7A53.1030907@xxxxxxxxx>
References: <20050520194220.GA18259@xxxxxxxxxxxxx> <20050520.152836.48528379.davem@xxxxxxxxxxxxx> <428E72F9.3070404@xxxxxxxxx> <20050520.164504.31639000.davem@xxxxxxxxxxxxx> <428E7A53.1030907@xxxxxxxxx>
Sender: netdev-bounce@xxxxxxxxxxx
On Fri, 2005-05-20 at 20:01 -0400, Jeff Garzik wrote:
> David S.Miller wrote:
> > From: Jeff Garzik <jgarzik@xxxxxxxxx>
> > Date: Fri, 20 May 2005 19:30:01 -0400
> > 
> > 
> >>Sure.  What I'm driving at is that a checksum of zero seems to imply 
> >>CHECKSUM_NONE not CHECKSUM_UNNECESSARY.  tg3 only does the 0xffff check.
> > 
> > 
> > Sure, both ways are fine.
> 
> huh?  They are pretty different...  one says "Checksum all good, dude" 
> and the other says "I didn't checksum, do it in software for me."
> 
> right?
> 

Yes, if the UDP checksum field in the UDP header is zero - meaning
checksum is not calculated for this packet, the calculated checksum done
by the chip will almost always be something other than 0xffff, and so it
will end up with CHECKSUM_NONE.


<Prev in Thread] Current Thread [Next in Thread>