netdev
[Top] [All Lists]

Re: assertion (!atomic_read(&sk->sk_rmem_alloc)) failed at net/netlink/a

To: herbert@xxxxxxxxxxxxxxxxxxx
Subject: Re: assertion (!atomic_read(&sk->sk_rmem_alloc)) failed at net/netlink/af_netlink.c (122)
From: "David S. Miller" <davem@xxxxxxxxxxxxx>
Date: Thu, 19 May 2005 12:47:16 -0700 (PDT)
Cc: tommy.christensen@xxxxxxxxx, chamas@xxxxxxxxxxxxx, netdev@xxxxxxxxxxx
In-reply-to: <20050511222210.GA21280@xxxxxxxxxxxxxxxxxxx>
References: <20050511005836.GA1674@xxxxxxxxxxxxxxxxxxx> <4282846F.6070403@xxxxxxxxx> <20050511222210.GA21280@xxxxxxxxxxxxxxxxxxx>
Sender: netdev-bounce@xxxxxxxxxxx
From: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>
Date: Thu, 12 May 2005 08:22:10 +1000

> > What about an alternative fix, that avoids even more cloning (where
> > possible)? This resurrects the skb_orphan call that was moved out, last
> > time we had 'shared-skb troubles'. It is practically a no-op in the
> > common case, but still prevents the possible race with recvmsg.
> > (And I have a weakness for one-line-fixes). :-)
> 
> Yep this is much better.  Thanks Tommy.
> 
> Acked-by: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>

Applied, thanks a lot guys.

<Prev in Thread] Current Thread [Next in Thread>