netdev
[Top] [All Lists]

Re: [PATCH] use lookup_create in af_unix

To: hch@xxxxxx
Subject: Re: [PATCH] use lookup_create in af_unix
From: "David S. Miller" <davem@xxxxxxxxxxxxx>
Date: Thu, 19 May 2005 12:27:56 -0700 (PDT)
Cc: netdev@xxxxxxxxxxx
In-reply-to: <20050512102336.GA26628@xxxxxx>
References: <20050512102336.GA26628@xxxxxx>
Sender: netdev-bounce@xxxxxxxxxxx
From: Christoph Hellwig <hch@xxxxxx>
Date: Thu, 12 May 2005 12:23:36 +0200

> currently it opencodes it, but that's in the way of chaning the
> lookup_hash interface.
> 
> I'd prefer to disallow modular af_unix over exporting lookup_create,
> but I'll leave that to you.
> 
> Signed-off-by: Christoph Hellwig <hch@xxxxxx>

This patch looks fine.  Applied, thanks Chirstophe.

Maybe someone should add to the comments above these fs/namei.c
functions that they will return with the semaphore held even
in error cases.

<Prev in Thread] Current Thread [Next in Thread>