On Thu, 19 May 2005, Jon Mason wrote:
This patch only enables the features which are common between all of the
bridged devices (at the time of their addition to the bridge). It overlooks
the cases where not all of the adapters have the same features, or where the
user has changed the enablement of a certain feature (via ethtool).
Thanks,
Jon
I agree that the patch doesn't take care of ethtool oprations.
I will correct this.
But, it doesn't overlook the case when "not all of the adapters have the
same features". If all devices have a feature, it is enabled on the bridge
interface. Else, it is cleared. Am I missing your point?
Thank you very much for looking over the patch!
On Thursday 19 May 2005 10:28 am, Catalin(ux aka Dino) BOIE wrote:
Hello!
The attached patch, makes the bridge to select features (almost all) only
if _all_ devices supports them.
The patch was tested (create a bridge, add an interface, remove the
interface and always check features flags).
What do you think?
Signed-off-by: Catalin(ux aka Dino) BOIE <catab at umbrella.ro>
---
Catalin(ux aka Dino) BOIE
catab at deuroconsult.ro
http://kernel.umbrella.ro/
---
Catalin(ux aka Dino) BOIE
catab at deuroconsult.ro
http://kernel.umbrella.ro/
|