Re: [PATCH] Super TSO

["David S. Miller" <davem@xxxxxxxxxxxxx>]

From: Andi Kleen <ak@xxxxxx>
Date: Wed, 18 May 2005 15:43:21 +0200

> > @@ -674,59 +653,274 @@ unsigned int tcp_sync_mss(struct sock *s
> >   * cannot be large. However, taking into account rare use of URG, this
> >   * is not a big flaw.
> >   */
> > +static inline u32 compute_xmit_cache(u32 mss, int sacks, int tso_enabled)
> > +{
> > +   u32 ret = (mss << 16) | sacks;
> 
> 16bit MSS? How does that deal with jumbopackets on IPv6?
> While the MSS option is also 16bit it is legal to construct bigger
> datagrams when no MSS option was exchanged.

It doesn't, and neither does the existing code.  I know it needs
to be fixed, thanks for reminding me.