netdev
[Top] [All Lists]

Re: Fw: [Bugme-new] [Bug 4628] New: Test server hang while running rhr (

To: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>
Subject: Re: Fw: [Bugme-new] [Bug 4628] New: Test server hang while running rhr (network) test on RHEL4 with kernel 2.6.12-rc1-mm4
From: Jeff Garzik <jgarzik@xxxxxxxxx>
Date: Mon, 16 May 2005 17:58:52 -0400
Cc: Ganesh Venkatesan <ganesh.venkatesan@xxxxxxxxx>, Andrew Morton <akpm@xxxxxxxx>, netdev@xxxxxxxxxxx, hejianj@xxxxxxxxxx, linuxppc64-dev@xxxxxxxxxxxxxxxxxxxxxxxxxx, anton@xxxxxxxxx
In-reply-to: <20050516212957.GA19211@xxxxxxxxxxxxxxxxxxx>
References: <20050516025901.4b26ccf3.akpm@xxxxxxxx> <E1DXdL8-0005mE-00@xxxxxxxxxxxxxxxxxxxxxxxx> <5fc59ff3050516104367a8d5cd@xxxxxxxxxxxxxx> <20050516212957.GA19211@xxxxxxxxxxxxxxxxxxx>
Sender: netdev-bounce@xxxxxxxxxxx
User-agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7.6) Gecko/20050328 Fedora/1.7.6-1.2.5
Herbert Xu wrote:
On Mon, May 16, 2005 at 10:43:02AM -0700, Ganesh Venkatesan wrote:

@@ -1708,11 +1778,15 @@ err_rx_clean_list:

static void e100_down(struct nic *nic)
{
+#ifdef CONFIG_E100_NAPI
+       /* wait here for poll to complete */
+       netif_poll_disable(nic->netdev);
+#endif


Sorry, you can't do that here since you're in softirq context and
netif_poll_disable may sleep.

I think the intention is that e100_down() may sleep, from looking at all the callsites.

Only e100_tx_timeout() calls it in a context that prevents sleep.

        Jeff



<Prev in Thread] Current Thread [Next in Thread>