Re: [PATCH 11/12] orinoco: monitor mode support

[Francois Romieu <romieu@xxxxxxxxxxxxx>]

Christoph Hellwig <hch@xxxxxx> :
[...]
> +     skb = dev_alloc_skb(hdrlen + datalen);
> +     if (!skb) {
> +             printk(KERN_WARNING "%s: Cannot allocate skb for monitor 
> frame\n",
> +                    dev->name);
> +             err = -ENOMEM;
> +             goto drop;
> +     }
> +
> +     /* Copy the 802.11 header to the skb */
> +     memcpy(skb_put(skb, hdrlen), &(desc->frame_ctl), hdrlen);
> +     skb->mac.raw = skb->data;
> +
> +     /* If any, copy the data from the card to the skb */
> +     if (datalen > 0) {
> +             err = hermes_bap_pread(hw, IRQ_BAP, skb_put(skb, datalen),
> +                                    ALIGN(datalen, 2), rxfid,
> +                                    HERMES_802_2_OFFSET);
> +             if (err) {
> +                     printk(KERN_ERR "%s: error %d reading monitor frame\n",
> +                            dev->name, err);
> +                     goto drop;
[...]
> + drop:
> +     stats->rx_errors++;
> +     stats->rx_dropped++;
> +}

-> leak (skb).

--
Ueimor