netdev
[Top] [All Lists]

[PATCH 1/4] iseries_veth: Don't send packets to LPARs which aren't up

To: Andrew Morton <akpm@xxxxxxxx>, Jeff Garzik <jgarzik@xxxxxxxxx>
Subject: [PATCH 1/4] iseries_veth: Don't send packets to LPARs which aren't up
From: Michael Ellerman <michael@xxxxxxxxxxxxxx>
Date: Thu, 12 May 2005 17:47:27 +1000
Cc: netdev@xxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx
Reply-to: michael@xxxxxxxxxxxxxx
Sender: netdev-bounce@xxxxxxxxxxx
User-agent: KMail/1.8
Hi Andrew, Jeff,

The iseries_veth driver has a logic bug which means it will erroneously
send packets to LPARs for which we don't have a connection.

This usually isn't a big problem because the Hypervisor call fails
gracefully and we return, but if packets are TX'ed during the negotiation
of the connection bad things might happen.

Regardless, the right thing is to bail early if we know there's no
connection.

Signed-off-by: Michael Ellerman <michael@xxxxxxxxxxxxxx>
--

 iseries_veth.c |    2 +-
 1 files changed, 1 insertion(+), 1 deletion(-)

Index: veth-fixes/drivers/net/iseries_veth.c
===================================================================
--- veth-fixes.orig/drivers/net/iseries_veth.c
+++ veth-fixes/drivers/net/iseries_veth.c       
@@ -924,7 +924,7 @@ static int veth_transmit_to_one(struct s
 
        spin_lock_irqsave(&cnx->lock, flags);
 
-       if (! cnx->state & VETH_STATE_READY)
+       if (! (cnx->state & VETH_STATE_READY))
                goto drop;
 
        if ((skb->len - 14) > VETH_MAX_MTU)

<Prev in Thread] Current Thread [Next in Thread>
  • [PATCH 1/4] iseries_veth: Don't send packets to LPARs which aren't up, Michael Ellerman <=