Re: [PATCH] fix long-standing bug in 2.6/2.4 skb_copy/skb_copy_expand

[Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>]

Stuffed Crust <pizza@xxxxxxxxxxxx> wrote:
> 
> This is, fortunately, generally true.  But if the alloc_skb function 
> allocates extra head room (ie calls skb_reserve() on the skb before it 
> passes it to the callee, this doesn't quite work.  Instead, it should be 
> rewritten as:

As far as I know the alloc_skb funciton in the kernel tree doesn't do
that so your patch is not necessary unless we decide to change the way
alloc_skb works.  If that's what you want then please provide a patch
to alloc_skb and a rationale as to why we should do that.

Cheers,
-- 
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@xxxxxxxxxxxxxxxxxxx>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt