netdev
[Top] [All Lists]

Re: [NET]: Avoid useless iterating in netlink dump functions

To: hadi@xxxxxxxxxx
Subject: Re: [NET]: Avoid useless iterating in netlink dump functions
From: Patrick McHardy <kaber@xxxxxxxxx>
Date: Fri, 06 May 2005 23:27:35 +0200
Cc: "David S. Miller" <davem@xxxxxxxxxxxxx>, Maillist netdev <netdev@xxxxxxxxxxx>
In-reply-to: <1115414222.13922.41.camel@xxxxxxxxxxxxxxxxxxxxx>
References: <427B8FC3.4000305@xxxxxxxxx> <1115413473.13922.38.camel@xxxxxxxxxxxxxxxxxxxxx> <427BDDD4.1000808@xxxxxxxxx> <1115414222.13922.41.camel@xxxxxxxxxxxxxxxxxxxxx>
Sender: netdev-bounce@xxxxxxxxxxx
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.7.7) Gecko/20050420 Debian/1.7.7-2
jamal wrote:
> On Fri, 2005-06-05 at 23:12 +0200, Patrick McHardy wrote:
> 
>>action dumping is on my list for more treatment than this :)
> 
> Well, that does sound scary ;-> What do you have in mind.
> Recall, there are two paths to dumping actions - unlike any other thing
> in the kernel.

Don't worry :) Its actually action walking that is on my list.
What I have planed is roughly:
- clean up and move hashing functions to act_common.c
- put data needed for hashing (size, pointer to memory, ...) in
  struct tc_act_common, which is referenced by struct tc_action_ops
- add callback based walking function so we don't need two of them

This should also get rid of all the large functions contained in
headerfiles.

Regards
Patrick

<Prev in Thread] Current Thread [Next in Thread>