netdev
[Top] [All Lists]

Re: netfilter6: ICMPv6 type 143 doesn't match

To: kaber@xxxxxxxxx (Patrick McHardy)
Subject: Re: netfilter6: ICMPv6 type 143 doesn't match
From: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>
Date: Fri, 06 May 2005 23:22:42 +1000
Cc: davem@xxxxxxxxxxxxx, dlstevens@xxxxxxxxxx, laforge@xxxxxxxxxxxx, netdev@xxxxxxxxxxx, netfilter-devel@xxxxxxxxxxxxxxxxxxx, pb@xxxxxxxxxxxx, usagi-users@xxxxxxxxxxxxxx, yasuyuki.kozakai@xxxxxxxxxxxxx, yoshfuji@xxxxxxxxxxxxxx
In-reply-to: <427AA319.1040906@xxxxxxxxx>
Organization: Core
Sender: netdev-bounce@xxxxxxxxxxx
User-agent: tin/1.7.4-20040225 ("Benbecula") (UNIX) (Linux/2.4.27-hx-1-686-smp (i686))
Patrick McHardy <kaber@xxxxxxxxx> wrote:
> 
> +static inline int mld_dev_queue_xmit2(struct sk_buff *skb)
> +{
> +       struct net_device *dev = skb->dev;
> +
> +       if (dev->hard_header) {
> +               unsigned char ha[MAX_ADDR_LEN];
> +               int err;
> +
> +               ndisc_mc_map(&skb->nh.ipv6h->daddr, ha, dev, 1);
> +               err = dev->hard_header(skb, dev, ETH_P_IPV6, ha, NULL, 
> skb->len);
> +               if (err < 0) {
> +                       IP6_INC_STATS(IPSTATS_MIB_OUTDISCARDS);

You're now incrementing this twice since the callers will also
increment this.

Cheers,
-- 
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@xxxxxxxxxxxxxxxxxxx>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

<Prev in Thread] Current Thread [Next in Thread>