| To: | Harald Welte <laforge@xxxxxxxxxxxxx> |
|---|---|
| Subject: | Re: CONFIG_NETFILTER_DEBUG spew |
| From: | Patrick McHardy <kaber@xxxxxxxxx> |
| Date: | Fri, 06 May 2005 00:36:35 +0200 |
| Cc: | Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>, netfilter-devel@xxxxxxxxxxxxxxxxxxx, netdev@xxxxxxxxxxx, "David S. Miller" <davem@xxxxxxxxxxxxx> |
| In-reply-to: | <20050505111457.GS30482@xxxxxxxxxxxxxxxxxxxxxxx> |
| References: | <20050501032809.3d0b4cda.akpm@xxxxxxxx> <20050501111507.GA2133@xxxxxxxxxxxxxxxxxxx> <4274F2ED.9080404@xxxxxxxxx> <20050505111457.GS30482@xxxxxxxxxxxxxxxxxxxxxxx> |
| Sender: | netdev-bounce@xxxxxxxxxxx |
| User-agent: | Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.7.7) Gecko/20050420 Debian/1.7.7-2 |
Harald Welte wrote: > On Sun, May 01, 2005 at 05:17:01PM +0200, Patrick McHardy wrote: > >>You're right. I'm tempted to remove the entire nf_debug stuff, >>as far as I know it has never found a real bug. But for now >>I've only fixed the warning. > > > yes, I second that change. At the same time, we should get rid of all > the lockhelp.h stuff that makes the netfilter code use non-standard lock > primitives. I've removed nf_debug. As for lockhelp.h, I'm still undecided whether I should try to make rwlock debugging a feature of standard rwlocks or else what to do with all the rwlock assertions. Regards Patrick |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: [IPV4]: multipath_wrandom.c GPF fixes, Patrick McHardy |
|---|---|
| Next by Date: | Re: netfilter6: ICMPv6 type 143 doesn't match, David S. Miller |
| Previous by Thread: | Re: CONFIG_NETFILTER_DEBUG spew, Harald Welte |
| Next by Thread: | Re: CONFIG_NETFILTER_DEBUG spew, Patrick McHardy |
| Indexes: | [Date] [Thread] [Top] [All Lists] |