netdev
[Top] [All Lists]

Re: [PATCH 2/3] add open iscsi netlink interface to iscsi transport clas

To: michaelc@xxxxxxxxxxx
Subject: Re: [PATCH 2/3] add open iscsi netlink interface to iscsi transport class
From: YOSHIFUJI Hideaki / 吉藤英明 <yoshfuji@xxxxxxxxxxxxxx>
Date: Thu, 05 May 2005 18:55:03 +0900 (JST)
Cc: linux-scsi@xxxxxxxxxxxxxxx, netdev@xxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, yoshfuji@xxxxxxxxxxxxxx
In-reply-to: <42798AC1.2010308@xxxxxxxxxxx>
Organization: USAGI Project
References: <42798AC1.2010308@xxxxxxxxxxx>
Sender: netdev-bounce@xxxxxxxxxxx
In article <42798AC1.2010308@xxxxxxxxxxx> (at Wed, 04 May 2005 19:53:53 -0700), 
Mike Christie <michaelc@xxxxxxxxxxx> says:

> +struct iscsi_uevent {
:
> +} __attribute__ ((aligned (sizeof(unsigned long))));

I think it'd be better to use sizeof(uint64_t) or something.
Please check other spots, too. e.g.:

> +     struct iscsi_stats_custom custom[0]
> +             __attribute__ ((aligned (sizeof(unsigned long))));

--yoshfuji

<Prev in Thread] Current Thread [Next in Thread>