| To: | Mark Broadbent <markb@xxxxxxxxxxxxxx> |
|---|---|
| Subject: | Re: [PATCH] Tulip interrupt uses non IRQ safe spinlock |
| From: | Paulo Marques <pmarques@xxxxxxxxxxxx> |
| Date: | Mon, 02 May 2005 15:16:11 +0100 |
| Cc: | linux-kernel@xxxxxxxxxxxxxxx, jgarzik@xxxxxxxxx, netdev@xxxxxxxxxxx |
| In-reply-to: | <E1DRFqC-00028H-Qi@tigger> |
| Organization: | Grupo PIE |
| References: | <E1DRFqC-00028H-Qi@tigger> |
| Sender: | netdev-bounce@xxxxxxxxxxx |
| User-agent: | Mozilla Thunderbird 1.0 (X11/20041206) |
Mark Broadbent wrote: The interrupt handling code in the tulip network driver appears to use a non IRQ safe spinlock in an interrupt context. The following patch should correct this. Huh? Can a network interrupt handler be interrupted by the same interrupt? AFAIK, the spin_lock_irqsave is to disable interruptions so that an interrupt can not happen in the critical section, so that the interrupt handler can not make modifications to shared data. Am I wrong? -- Paulo Marques - www.grupopie.com All that is necessary for the triumph of evil is that good men do nothing. Edmund Burke (1729 - 1797) |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: icmp_unreachable uses wrong ip, Hasso Tepper |
|---|---|
| Next by Date: | Re: icmp_unreachable uses wrong ip, Patrick McHardy |
| Previous by Thread: | Re: [PATCH] Tulip interrupt uses non IRQ safe spinlock, Herbert Xu |
| Next by Thread: | Re: [PATCH] Tulip interrupt uses non IRQ safe spinlock, Jeff Garzik |
| Indexes: | [Date] [Thread] [Top] [All Lists] |