netdev
[Top] [All Lists]

Re: Fw: [Bugme-new] [Bug 4628] New: Test server hang while running rhr (

To: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>
Subject: Re: Fw: [Bugme-new] [Bug 4628] New: Test server hang while running rhr (network) test on RHEL4 with kernel 2.6.12-rc1-mm4
From: Ganesh Venkatesan <ganesh.venkatesan@xxxxxxxxx>
Date: Thu, 26 May 2005 16:08:17 -0700
Cc: "Venkatesan, Ganesh" <ganesh.venkatesan@xxxxxxxxx>, Andrew Morton <akpm@xxxxxxxx>, Jian Jun He <hejianj@xxxxxxxxxx>, anton@xxxxxxxxx, rende@xxxxxxxxxx, "Brandeburg, Jesse" <jesse.brandeburg@xxxxxxxxx>, jgarzik@xxxxxxxxx, wangjs@xxxxxxxxxx, "Ronciak, John" <john.ronciak@xxxxxxxxx>, cdlwangl@xxxxxxxxxx, linuxppc64-dev@xxxxxxxxxxxxxxxxxxxxxxxxxx, netdev@xxxxxxxxxxx
Domainkey-signature: a=rsa-sha1; q=dns; c=nofws; s=beta; d=gmail.com; h=received:message-id:date:from:reply-to:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; b=Za1tN+o7B8ceBG8jx2iAeC/GHgB9aZEOvslcBRi2cIkGLMdrSK+mLH6qR9oPSde4HcxadQMeqekyTYCmzFI/NXWCvoMTMT3FMDwLLA4OipPDTkZBaoUxif1ymwuqw2lCTnlrVi28QK0I21WgXEe+frPZwa9UkFm6xPlUtq+Uhpk=
In-reply-to: <20050526213421.GA8077@gondor.apana.org.au>
References: <468F3FDA28AA87429AD807992E22D07E056F6B37@orsmsx408> <20050526213421.GA8077@gondor.apana.org.au>
Reply-to: Ganesh Venkatesan <ganesh.venkatesan@xxxxxxxxx>
Sender: netdev-bounce@xxxxxxxxxxx
Herbert:

I do not get it. Bear with my ignorance.

e100_tx_timeout does not call e100_down. 

It is called from e100_tx_timeout_task which is invoked as a result of
schedule_work. Are you saying that it would still not have the right
context to call netif_disable_poll()?

thanks,
ganesh.

On 5/26/05, Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx> wrote:
> On Thu, May 26, 2005 at 01:41:53PM -0700, Venkatesan, Ganesh wrote:
> >
> > I already responded to this analysis before. In any case, here it is:
> >
> > Later versions of e100 (3.4.8 for instance) includes a call to
> > netif_poll_disable in e100_down. This is supposed to wait and when it
> 
> As I said last time, this is broken since the code path in question
> starts from tx_timeout which is called in softirq context.  You'll
> need to schedule a work struct at least.
> 
> Cheers,
> --
> Visit Openswan at http://www.openswan.org/
> Email: Herbert Xu ~{PmV>HI~} <herbert@xxxxxxxxxxxxxxxxxxx>
> Home Page: http://gondor.apana.org.au/~herbert/
> PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
>


<Prev in Thread] Current Thread [Next in Thread>