netdev
[Top] [All Lists]

Re: [PATCH 2.6] fix deadlock with ip_queue and tcp local input path

To: "David S. Miller" <davem@xxxxxxxxxxxxx>
Subject: Re: [PATCH 2.6] fix deadlock with ip_queue and tcp local input path
From: Harald Welte <laforge@xxxxxxxxxxxxx>
Date: Thu, 26 May 2005 22:58:31 +0200
Cc: netfilter-devel@xxxxxxxxxxxxxxxxxxx, netdev@xxxxxxxxxxx
In-reply-to: <20050526.135229.111208218.davem@davemloft.net>
Mail-followup-to: Harald Welte <laforge@xxxxxxxxxxxxx>, "David S. Miller" <davem@xxxxxxxxxxxxx>, netfilter-devel@xxxxxxxxxxxxxxxxxxx, netdev@xxxxxxxxxxx
References: <20050526142420.GD13114@sunbeam.de.gnumonks.org> <20050526.135229.111208218.davem@davemloft.net>
Sender: netdev-bounce@xxxxxxxxxxx
User-agent: mutt-ng 1.5.8-r168i (Debian)
On Thu, May 26, 2005 at 01:52:29PM -0700, David S. Miller wrote:
 
> > Dave: Please don't apply yet, I want to receive feedback from the
> > netfilter developers first.  I'm just Cc'ing netdev in case somebody
> > wants an intermediate fix to fix the problem.
> 
> OK.

Do you have any feedback on why or how bh_lock_sock() might be called in
the problem I've described?  I think it has to be a different skb for
the same socket.

Is my general line of thought correct that we shouldn't traverse the
local input path from sysirq context ?

Thanks.

-- 
- Harald Welte <laforge@xxxxxxxxxxxxx>                 http://netfilter.org/
============================================================================
  "Fragmentation is like classful addressing -- an interesting early
   architectural error that shows how much experimentation was going
   on while IP was being designed."                    -- Paul Vixie

Attachment: pgpTlfaaeDayX.pgp
Description: PGP signature

<Prev in Thread] Current Thread [Next in Thread>